DownloadableBlocksPanel: remove withSelect in favor of useSelect #58109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Code Quality
|
Size Change: -6 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jan 23, 2024
| @@ -35,7 +29,6 @@ function InserterMenuDownloadableBlocksPanel() { | |||
| <DownloadableBlocksPanel | |||
| onSelect={ onSelect } | |||
| onHover={ onHover } | |||
| rootClientId={ rootClientId } | |||
There was a problem hiding this comment.
Yes, the prop was not used 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing something I noticed when discussing #58058:
DownloadableBlocksPanelis a functional component and yet it useswithSelect. This PR migrates that to a custom hook withuseSelect.How to test: Open block inserter in the left sidebar. Try to search for something. Verify that you are offered a list of downloadable matching blocks from the WP.org registry.